Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45674 )
Change subject: realtek_mst_i2c_spi.c: Introduce MCU reset param ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/45674/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/45674/3//COMMIT_MSG@10 PS3, Line 10: MCU unless explicitly stated by a param.
In which cases would one want to reset the MCU?
I suppose this is not unlike 'noreset' in mstarddc_spi.c. Basically the reset causes the MCU to jmp to either the A or B fw image from the bootloader depending on some other flow.
We hope to update the comments in the source once we actually have that side of things pinned down as we do not directly control the firmware environment.
This sort of thing is a little tricky because Flashrom was not really designed to handle the runtime state of the thing it is flashing and so we do not really want to introduce that complexity here only just to be able to tune a very basic artifact of the runtime (i.e., reset after flashing).