Attention is currently required from: Cattus QQ.
Anastasia Klimchuk has posted comments on this change by Cattus QQ. ( https://review.coreboot.org/c/flashrom/+/85929?usp=email )
Change subject: Update glasgow info on hardware overview ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: thanks for the patch! I have few comments, below
Commit Message:
https://review.coreboot.org/c/flashrom/+/85929/comment/94ac167e_b367691d?usp... : PS1, Line 6: : Update glasgow info on hardware overview We usually add a prefix to commit message, to give an idea which part of the code is changed, in this case the prefix would be `doc:`
The title itself is all good, so the end result can be:
`doc: Update glasgow info on hardware overview`
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/85929/comment/9a7ea107_9858f8a8?usp... : PS1, Line 98: ============== The underline only need to last for as long as the title last, so the remaining `=` can be removed. It doesn't change how webpage looks, but that's redundant chars
https://review.coreboot.org/c/flashrom/+/85929/comment/5fad957c_424d7a15?usp... : PS1, Line 105: The official website can be found here: `glasgow-embedded.org https://glasgow-embedded.org`_. It's up to you, but I just wanted to say: single new line in source .rst file does not produce a new line in html. So currently, the text from lines 103 to 107 is generated as one paragraph without new lines. If you would like to frame official website info, sources and examples with new lines (which is I think they deserve), you need to add 2 (two) new lines in the .rst source.
File util/git-hooks/commit-msg:
https://review.coreboot.org/c/flashrom/+/85929/comment/50f671d6_51fcdcf0?usp... : PS1, Line 203: #exit 1 This shouldn't be in the patch? probably by mistake?
did you have issues with git hook checker for sign off line? (I can see the patch has sign off line, good :) )