Hello David Hendricks, Stefan Reinauer, build bot (Jenkins), Alan Green, Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35611
to look at the new patch set (#5).
Change subject: cli_classic: Tidy up some repeated handling patterns into funcs ......................................................................
cli_classic: Tidy up some repeated handling patterns into funcs
Introduce cli_classic_single_operation() to consolidate the repeating pattern of multiple CLI operations at once. Also modify cli_classic_abort_usage() to take an optional error abort string and print it to stderr, this allows for trimming a few more lines off the cli implementation.
V.2: A few fixes upon review: - Trim off some unnecessary braces for single line branches. - Pass 'operation_specified' by reference. - Rename a function.
Change-Id: I54598efdaee2b95cb278b0f2aac05f48bbd95bef Signed-off-by: Edward O'Callaghan quasisec@chromium.org --- M cli_classic.c 1 file changed, 63 insertions(+), 130 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/35611/5