Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46448 )
Change subject: realtek_mst_i2c_spi.c: Trigger gpio 88 toggle down after write ......................................................................
Patch Set 1: Code-Review+2
I'd have a `const bool wp_enable` to see how this toggles the write-protect state:
/* Write-protect is active low */ const bool wp_enable = false;
realtek_mst_i2c_spi_toggle_gpio_88_strap(fd, !wp_enabled);
/* do stuff */
realtek_mst_i2c_spi_toggle_gpio_88_strap(fd, wp_enabled);
But then again, it's not really a big deal.