4 May
2017
4 May
'17
10:55 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/19044 )
Change subject: ich_descriptors: Fix more odd +1's ......................................................................
Patch Set 3: Code-Review-1
(3 comments)
Sorry, it's still confusing...
https://review.coreboot.org/#/c/19044/3/ich_descriptors.c File ich_descriptors.c:
PS3, Line 620: Just realized that I killed this whitespace by accident.
PS3, Line 619: sizeof(desc->north.STRPs) / 4 Isn't it just ARRAY_SIZE()?
PS3, Line 619: + 1 This seems off, too.
--
To view, visit https://review.coreboot.org/19044
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa5455c999e90ff9121aed29f542d71ac9ca2b1c
Gerrit-PatchSet: 3
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-HasComments: Yes