Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 )
Change subject: flashchips: add support for ISSI IS25LP016 ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68295/comment/f93c53a3_a4605b6a PS1, Line 7: flashchips.c
just "flashchips"
Done
https://review.coreboot.org/c/flashrom/+/68295/comment/01da1934_71dac8b2 PS1, Line 10: Everything
Alternatively, list what has been tested and add "No issues found so far" or similar.
To me current version looks fine ("Reading, erasing and writing works"). I am marking as resolved, but if you (Felix, Angel) disagree please tell!
Patchset:
PS2: Mario, I discovered that you have fixed the comments in your latest patchset, just haven't marked them as done :) When you are working on a patch, and uploading new patchset, you usually reply to the comments from your reviewers: either reply Done (if done) or ask for clarification if the comment is unclear, or you are not sure what to do with it. Otherwise I can be confusing, because patch has unresolved and unreplied comments - and reviewers might think that you are still working on it and it's not ready for next round of reviews. Thank you!
For this patch: it needs rebasing, and also probably Felix and Angel would like to have another look after comments are resolved.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/68295/comment/4d26d611_2e6af0d5 PS1, Line 7381:
We use tabs to align the equals signs
Done