Attention is currently required from: Felix Singer, Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58276 )
Change subject: platform.h: remove IS_LINUX and IS_MACOSX macros
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58276/comment/68b20950_08670b7a
PS2, Line 7: macro
`macros`
Done
https://review.coreboot.org/c/flashrom/+/58276/comment/52699650_a4f7818e
PS2, Line 9: Replace the remaining uses by the plain macros.
Add an empty line to split paragraphs?
Done
https://review.coreboot.org/c/flashrom/+/58276/comment/ec610bda_284d9632
PS2, Line 11: easily
Missing a word here, `can easily *be* handled`?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I23ec8fdcff8202d10ddf5a7520432e5b26b01cd4
Gerrit-Change-Number: 58276
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 13 Oct 2021 19:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment