Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43573 )
Change subject: Add support for Winbond W25X05CL ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/flashrom/+/43573/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43573/1//COMMIT_MSG@10 PS1, Line 10: 4KB
4 KiB
Done
https://review.coreboot.org/c/flashrom/+/43573/1//COMMIT_MSG@10 PS1, Line 10: 512K-BIT
512 Kib (64 KiB)
Done
https://review.coreboot.org/c/flashrom/+/43573/1//COMMIT_MSG@15 PS1, Line 15: Datasheet: http://www.winbond.com/resource-files/w25x05cl_f%2004252017.pdf
Links tend to rot, so I wouldn't add it to the commit message
Done