Attention is currently required from: Martin L Roth, Thomas Heijligen, Arthur Heymans.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 )
Change subject: flashrom: rename sb600spi.c to amd_spi.c
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
The promontary support works well in that patch series linked. […]
Thinking a bit more about it, and returning back to the point of the patch. I like amd_spi.c more than amd_sb600_spi.c : it's a shorter name without loss of information. Commit message explains that "sb600" doesn't give any information, so why keep it in the name?
So I support renaming to amd_spi.c
(what is going on on the other forks is not that relevant for this question)
And I am still interested if there are any longer term plans that maybe Martin you have?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74952
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13859de27e602cc6496684e6cb66b2dc2e21531a
Gerrit-Change-Number: 74952
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 08 May 2023 10:26:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment