David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44517 )
Change subject: udelay.c: Enable providing delay calibration value through CLI ......................................................................
Patch Set 2: Code-Review-1
(4 comments)
Thanks, Hrvoje. I think the code looks good, I just have a few cosmetic nits.
https://review.coreboot.org/c/flashrom/+/44517/2/flashrom.8.tmpl File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/44517/2/flashrom.8.tmpl@371 PS2, Line 371: provide s/provide a/cause
https://review.coreboot.org/c/flashrom/+/44517/2/flashrom.8.tmpl@370 PS2, Line 370: on a large : number of hosts Although you're correct, I think it's best to leave this out since "a large number of hosts" is an uncommon scenario. The "repeated execution" aspect is convincing on its own.
https://review.coreboot.org/c/flashrom/+/44517/2/udelay.c File udelay.c:
https://review.coreboot.org/c/flashrom/+/44517/2/udelay.c@236 PS2, Line 236: Ignore using the system clock for loop timing This comment seems more confusing than helpful. IIUC we're just ignoring the externally provided value.
https://review.coreboot.org/c/flashrom/+/44517/2/udelay.c@242 PS2, Line 242: /* Ignore using the system clock for loop timing */ Similar as above, the comment seems confusing (if I understand the intention correctly)