Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62745 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Isn't it just repeating the Makefile this way? Does it make a difference […]
I'm not sure I understand your question.
I think we want warnings as errors enabled for most of the jenkins builds. I just want a way to override it. Jenkins uses this script for the build, and because it's specified on the command line inside the script, I wasn't able to change it. so that I could get a complete build with -fanalyzer turned on.
I mean, we could get rid of the script completely and just hardcode each of the jenkins build tasks to do what this does if that's what you're suggesting, but then members of the project wouldn't be able to update the build task.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 62745
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@tutanota.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 30 May 2022 18:10:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment