Attention is currently required from: Alan Green, Nico Huber, Samir Ibradžić.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55695 )
Change subject: ft2232_spi: Revise comments about output pin states
......................................................................
Patch Set 1:
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/55695/comment/ebf7e590_7901d2a1
PS1, Line 98: * TCK/SK is bit 0.
: * TDI/DO is bit 1.
: * TDO/DI is bit 2.
: * TMS/CS is bit 3.
: * GPIOL0 is bit 4.
: * GPIOL1 is bit 5.
: * GPIOL2 is bit 6.
: * GPIOL3 is bit 7.
I don't know, the identifiers wouldn't be used in the code. It's mostly […]
I was thinking of using these in the code where we handle the `type` programmer param. Still, it's something that can be discussed later.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2b84ede01759c80f69d5ad17e43783d09ecd1107
Gerrit-Change-Number: 55695
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Sun, 20 Jun 2021 15:11:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment