Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34234 )
Change subject: flashchips: Add Macronix MX25L51245G ......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
Patch Set 1: Code-Review+2
(1 comment)
Hi, welcome and thanks for sending this change!
Looks pretty good, just a minor suggestion about the commit summary (which you can easily address with the gerrit web interface).
Patch Set 1: Code-Review+1
I see that your one of the maintainer of flashrom, I request for a review for addition of this flash type.
Usually, giving code-review scores to one's own changes is discouraged (the idea is that others review and give a score to your change). But as this is your first change in gerrit, I understand it's just a rookie mistake, no big deal :)
Point noted. Usually some projects request a +1 as a way of communicating the change was tested locally with hardware :)
Ack, here we usually state that in the commit message. But for flash chips this can be reflected on the code.
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/34234/2/flashchips.c@7789 PS2, Line 7789: .tested = TEST_OK_PREW, This tells me that probe, read, erase and write are working (or should be)