Attention is currently required from: Angel Pons, Nikolai Artemiev, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 )
Change subject: spi25_statusreg: make register read/write functions generic
......................................................................
Patch Set 15:
(5 comments)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/58475/comment/0def2c24_691dc89a
PS14, Line 126:
should be a tab
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/60c10b1e_a8b5145d
PS14, Line 134:
nit: double blank line
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/c7493f17_9a9d4001
PS14, Line 149:
nit: double blank line
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/c974a017_40a55a4a
PS14, Line 194: spi_write_register failed.
Would be good to indicate which register failed: […]
Done
https://review.coreboot.org/c/flashrom/+/58475/comment/60efef12_bce372e7
PS14, Line 207: spi_write_register failed.
Ditto
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58475
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a3951bbf993f2d8d830143b29d3ce16cc6901d7
Gerrit-Change-Number: 58475
Gerrit-PatchSet: 15
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Wed, 15 Dec 2021 15:08:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment