[flashrom-gerrit] [S] Change in flashrom[master]: meson: Move programmer test sources into programmer definition

[Felix Singer (Code Review)]

Attention is currently required from: Thomas Heijligen, Angel Pons, Anastasia Klimchuk.

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 )

Change subject: meson: Move programmer test sources into programmer definition
......................................................................

Patch Set 10:

(1 comment)

File tests/meson.build:

https://review.coreboot.org/c/flashrom/+/68162/comment/644c655c_81276543 
PS10, Line 32:   p_data += {
             :     'testsrc' : p_data.get('testsrc', []),
             :   }
             :   srcs += p_data.get('testsrc')
> Since not every programmer has tests, we would have to define an empty list of testsrc in the progra […]

See also line 440 in the top-level meson file. It's done the same way there. We could add the corresponding lines from here too so that the list of fields is "complete". So this meson file would only iterate over the programmers and add the source files to the srcs list.

What do you think? :)