5 Apr
2022
5 Apr
'22
11:53 a.m.
Attention is currently required from: Nico Huber, Arthur Heymans. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63258 )
Change subject: ch341a_spi.c: Reset device before use ......................................................................
Patch Set 1:
(1 comment)
File ch341a_spi.c:
https://review.coreboot.org/c/flashrom/+/63258/comment/c85474e4_e6a02306 PS1, Line 452: if (ret != 0) { From the libusb API doc: "If the reset fails, [...]. This means that the device handle is no longer valid [...]."
A no longer valid libusb handle is not caught.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff824c22dc871bb2d9504abe8b5ad4e4c191c4af
Gerrit-Change-Number: 63258
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 05 Apr 2022 18:53:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment