Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64029 )
Change subject: meson: relocate config_print_wiki & config_default_programmer_* ......................................................................
Patch Set 3:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64029/comment/8a44d6c1_414dc600 PS2, Line 417: cargs += '-DCONFIG_DEFAULT_PROGRAMMER_ARGS="' + config_default_programmer_args + '"'
Anastasia is correct, we do have the use-case of the default programmer and this is typically "inter […]
Funfact, I've added this only 11 month ago to meson. CB:55123 Maybe we can improve this option e.g. -Dclassic_cli_default_programmer=internal:boardenable=force and clean up the code for it in cli_classic.
In the long run this may become problematic when cli_classic doesn't depend anymore on internal symbols and we can't check if the programmer exists in the C code. Then we have to fallback checking for the programmer availability in meson and passing the programmer name as string. This works until we change the shared library against one without the default programmer in it. In this case we can only throw an error for it.
Maybe we should start a discussion how to deal with it?