Attention is currently required from: Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52492 )
Change subject: linux_spi.c: Resolve comments left from previous patches
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52492/comment/b14c57c2_3454f5aa
PS1, Line 7: linux_spi.c: Resolve comments left from previous patches
The summary should be about the changes, not what led to them :)
Maybe something like this:
linux_spi: Drop some unnecessary initialisations and checks
Patchset:
PS1:
Thanks for the quick reaction! I don't see it as your
responsibility to fix things up after a patch is merged
btw., but it's really nice that you did :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I27a718b515fc474f63b3e61be58a6f9302527559
Gerrit-Change-Number: 52492
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sam McNally
sammc@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 22 Apr 2021 11:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment