Daniel Verkamp has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46310 )
Change subject: pcidev.c: populate IDs with pci_fill_info() ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46310/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46310/1//COMMIT_MSG@10 PS1, Line 10: because the vendor_id and device_id fields of struct : pci_dev are not filled in I did not dig into the history to find the exact pciutils change, but the ChangeLog entry for 3.7.0 (from 2020-05-1) says:
Semantics of pci_fill_info() and pci_dev->known_fields was underspecified, which lead to inconsistencies between back-ends. Improved documentation to give a more precise definition and updated all back-ends to conform to it. Most importantly, pci_dev->known_fields shows all fields requested over the lifetime of the pci_dev, but never those which are not supported by the back-end.
The pciutils library API is almost undocumented, but I believe the pci_fill_info() call was always intended to be required; I verified that it has been around since at least a release from 1999, and it is used in example.c in pciutils.