Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41622 )
Change subject: tests/: Add CMocka unit-test infrastructure ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/flashrom/+/41622/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41622/3//COMMIT_MSG@10 PS3, Line 10: meson Only meson? It would be nice to handle the "we have two build systems" problem someday. AFAIK, Jenkins uses the Makefile to build-test things, and it would be good to run these tests automatically.
@pgeorgi any ideas? How much hassle would be to have Jenkins run the unit tests alongside build tests?
https://review.coreboot.org/c/flashrom/+/41622/3/tests/include/test.h File tests/include/test.h:
https://review.coreboot.org/c/flashrom/+/41622/3/tests/include/test.h@2 PS3, Line 2: /* This file is part of the coreboot project. */ This was dropped in upstream coreboot
https://review.coreboot.org/c/flashrom/+/41622/3/tests/tests.c File tests/tests.c:
PS3: No license headers here?