Nico Huber has posted comments on this change. ( https://review.coreboot.org/18738 )
Change subject: Fix linking with libpayload
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/18738/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/18738/6//COMMIT_MSG@9
PS6, Line 9: o flashbuses_to_text() is a cli function and should actually be moved
: or not be called from flashrom.c.
Why not move flashbuses_to_text() to flashrom.c?
Probably because I couldn't bear to move broken code (all
these possible NULL pointers) without fixing it. But it seems
the right thing, so I moved it now.
--
To view, visit
https://review.coreboot.org/18738
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I561135209b819361d125eeaeef9ff886d6bae987
Gerrit-Change-Number: 18738
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philippe Mathieu-Daudé
philippe.mathieu.daude@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 14 Jun 2017 11:51:52 +0000
Gerrit-HasComments: Yes