Attention is currently required from: Edward O'Callaghan, Liam Flaherty, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: debug_raiden_spi: Remove fixme with explanation
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68364/comment/9fb86b25_6eac53c2
PS1, Line 14: TICKET=https://ticket.coreboot.org/issues/394
I am terribly sorry, I made a mistake and told you to do the wrong thing, it actually should be
`Ticket: https://ticket.coreboot.org/issues/394%60
Sorry, I messed this with something else and forgot the format that we agreed on earlier.
The right thing to do is of course add the info to Development guidelines (linking tickets to patches). I will do that later...
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68364
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43e364c02f42dd499d3c9ca3e0a03ead673da3e6
Gerrit-Change-Number: 68364
Gerrit-PatchSet: 1
Gerrit-Owner: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Liam Flaherty
liamflaherty@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 13 Oct 2022 23:16:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment