Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39963 )
Change subject: nicintel: add I350 support
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/39963/1/nicintel_eeprom.c
File nicintel_eeprom.c:
https://review.coreboot.org/c/flashrom/+/39963/1/nicintel_eeprom.c@477
PS1, Line 477: uintptr_t io_base_addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_0);
it is needed as my platform is arm64 and the BAR0 has an address above the 32 bit boundary even if t […]
Well, there may be many more instances of uint32_t to store addresses, so it would be a good idea to take care of them all at once
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39963
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id203d2ce247cf39a8d650887322ccced0151c6a9
Gerrit-Change-Number: 39963
Gerrit-PatchSet: 1
Gerrit-Owner: Martijn Berger
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Comment-Date: Wed, 01 Apr 2020 08:43:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martijn Berger
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment