Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59709 )
Change subject: spi25_statusreg.c: support reading/writing security register
......................................................................
Patch Set 29:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/59709/comment/46c9c627_71b5602e
PS28, Line 9: Not to be confused with "secure registers" of OTP.
include this remark in the comment above the `FEATURE_SCUR` define?
Done
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/59709/comment/26d64748_a3250614
PS28, Line 104: use special commands for modifying it
IIRC, this path shouldn't be taken. So it's more a message for developers […]
Changed to:
```
/*
* Security register doesn't have a normal write operation. Instead,
* there are separate commands that set individual OTP bits.
*/
msg_cerr("Cannot write SECURITY: unsupported by design\n");
```
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iae1753ca4cb051127a5bcbeba7f064053adb8dae
Gerrit-Change-Number: 59709
Gerrit-PatchSet: 29
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 06 Oct 2022 21:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment