Attention is currently required from: Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt. ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
Code style is completely different, is this intentional? Are there plans to keep this in sync with m […]
Not really. I just copied and tested it. I will adapt it
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/73102/comment/f9207839_b86b1c56 PS1, Line 13: #if 0
Hmmmm
Yea, this should be replaces by flashroms error message.
File include/cli_classic.h:
https://review.coreboot.org/c/flashrom/+/73102/comment/ed210e62_5c5c655f PS1, Line 5: __has_include
Interesting, is this standard in the C version we use?
This is an extension supported by GCC >=5, clang, Apple clang, MSVC 19.11 (Microsoft VS2017).
From c23 it is also in the standard.
I started to use it to make the headers simpler.