28 Jan
2021
28 Jan
'21
2:22 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47908 )
Change subject: Makefile: Explicitly set '-std=c99' ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
GNU extensions break compilation (on at least one OS) outside linux. […]
Hi Idwer, POSIX_C_SOURCE=200809L is required for fileno, nanosleep, and strndup. This isn't the same thing as -D_GNU_SOURCE. We just make the assumptions from the toolchain explicit with flags in this commit, this should be a nop across any and all OS's we build on. If you know of a specific case where something is actually broken can you point that out so we can investigate?
--
To view, visit https://review.coreboot.org/c/flashrom/+/47908
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4f973927fc018510a3beaa6c4fa2f356c77c7a6e
Gerrit-Change-Number: 47908
Gerrit-PatchSet: 5
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Jan 2021 00:22:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Gerrit-MessageType: comment