[flashrom-gerrit] Change in flashrom[master]: mec1308.c: Separate shutdown from failed init cleanup

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52597 )

Change subject: mec1308.c: Separate shutdown from failed init cleanup
......................................................................

Patch Set 2:

(1 comment)

File mec1308.c:

https://review.coreboot.org/c/flashrom/+/52597/comment/c726989a_0c445551 
PS1, Line 520: /* Exit passthru mode before performing commands which do not affect
             : 	   the SPI ROM */
             : 	mec1308_exit_passthru_mode(ctx_data);
             : 
             : 	/* Re-enable SMI and ACPI.
             : 	   FIXME: is there an ordering dependency? */
             : 	if (mbx_write(ctx_data, MEC1308_MBX_CMD, MEC1308_CMD_SMI_ENABLE))
             : 		msg_pdbg("%s: unable to re-enable SMI\n", __func__);
             : 	if (mbx_write(ctx_data, MEC1308_MBX_CMD, MEC1308_CMD_ACPI_ENABLE))
             : 		msg_pdbg("%s: unable to re-enable ACPI\n", __func__);
> Could we just call mec1308_shutdown() here? Would have to skip the free() below, though: […]

Done