Attention is currently required from: Edward O'Callaghan. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64374 )
Change subject: flashrom.c: wrap chip->write() with a helper ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: With the current state of the patch I does not see any benefit. This may change with a follow up patch
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/64374/comment/45178087_5a9e8236 PS1, Line 1050: * @flash flash chip We have different documentation styles in the code. @flash @param flash We should unify this. I think `@param ...` is the one Doxygen and other tools recognize.
https://review.coreboot.org/c/flashrom/+/64374/comment/5e6ea690_1f953be4 PS1, Line 1054: * Document the return code
https://review.coreboot.org/c/flashrom/+/64374/comment/420379cf_b4a47dbb PS1, Line 1055: * TODO: Look up regions that are write-protected and avoid attempt to write Resolve the TODO? Maybe publish a follow up for it.