Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35611 )
Change subject: cli_classic: Tidy up some repeated handling patterns into funcs ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
LGTM, but waiting for Stefan's ack on the open comment.
https://review.coreboot.org/c/flashrom/+/35611/3/cli_classic.c File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35611/3/cli_classic.c@a430 PS3, Line 430: if ((read_it | write_it | verify_it) && check_filename(filename, "image")) { : cli_classic_abort_usage(); : } : if (layoutfile && check_filename(layoutfile, "layout")) { : cli_classic_abort_usage(); : } : if (fmapfile && check_filename(fmapfile, "fmap")) { : cli_classic_abort_usage(); : } : if (referencefile && check_filename(referencefile, "reference")) { : cli_classic_abort_usage(); : }
It was requested in the previous review? I don't think this is defensive much here as there isn't an […]
I didn't express my concerns properly on my comment on patchset 2. What I was thinking of was not about the braces, but rather reducing the number of printed strings.
However, now that I see it, I agree it would result in a less "defensive" coding style, so I wouldn't change it now. Apologies for the noise.