Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 )
Change subject: tests: Upgrade linux_spi test to run probe lifecycle
......................................................................
Patch Set 2:
(1 comment)
File tests/lifecycle.c:
https://review.coreboot.org/c/flashrom/+/59742/comment/89f1181f_1c4443e8
PS2, Line 336: W25Q128.V
So, this should be expected to fail, but happens to work because the chip
was successfully probed earlier with the dummy programmer and flashrom
caches the chip IDs. I tried moving the linux_spi test on top of main()
and then it failed (with some undefined behavior afterwards, so there's
still something to look into :-/)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72
Gerrit-Change-Number: 59742
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 17 Jan 2022 00:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment