Attention is currently required from: Felix Singer, Martin Roth, Edward O'Callaghan, Angel Pons, Nikolai Artemiev. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62768 )
Change subject: flashrom.8.tmpl: Add raiden_debug_spi doc entry ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Nico, please refrain from condescending comments on code review. […]
Edward, please refrain from treating every criticism as condescending. And how is this not actionable? You seem to document what you think the driver should do instead of looking into what it does. A reviewer needs to check the latter. You have all means to make the review easier, please do so.
About your constant request for actionable items only: Where did you learn that? That's not how we review in this project, AFAICT. Reviewers used to be treated with respect here. If you request from reviewers to tell you exactly what to do, you kind of make them kindergarten teachers.
File flashrom.8.tmpl:
https://review.coreboot.org/c/flashrom/+/62768/comment/511721ea_74adbb3e PS3, Line 1166: false
Like I said, false is implicit. […]
Sorry, misread that part in the new version. It still looks to me like `custom_rst=false` would be valid to pass even though it's the default. `<true>` doesn't work, btw., it's just `true`.