Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33613 )
Change subject: spi: Move 16MiB partitioning up into spi_chip_read() ......................................................................
Patch Set 3: Code-Review+1
This works perfectly now with dediprog + MX66L51235F!
Before I had the error:
$ flashrom -p dediprog -r test.bios flashrom v1.1-rc1-12-ga724602-dirty on Linux 4.19.37-2rodete1-amd64 (x86_64) flashrom is free software, get the source code at https://flashrom.org
Using clock_gettime for delay loops (clk_id: 1, resolution: 1ns). Incomplete/failed Command Receive Device String! Found Macronix flash chip "MX66L51235F" (65536 kB, SPI) on dediprog. Reading flash... SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! SPI bulk read failed! Read operation failed! FAILED.