Hello Edward O'Callaghan, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35037
to look at the new patch set (#2).
Change subject: flashchips.c: Put SFDP-capable chip back into position ......................................................................
flashchips.c: Put SFDP-capable chip back into position
Put entry for Unknown SFDP-capable chip back into place at end of file.
Change 1f9cc7d89992114c70f7a0545ad9f98701bebe56 "flashchips.c: Sort file by vendor and model" reordered many entries in flashchips.c, including this one. However, the entry for Unknown, SFDP-capable chip should not have been moved before any specific chip entries.
As reported by Angel Pons th3fanbus@gmail.com at https://review.coreboot.org/c/flashrom/+/33931:
""" Oops, this introduced a bug: the SFDP entry is no longer at the end of flashchips.c, so probing on a SFDP-capable Winbond chip results in added noise (flashrom says things about an unknown chip, and then has two definitions for the same chip). """
Signed-off-by: Alan Green avg@google.com Change-Id: I5955020456dbcd5e7db280a459b668a743e464dc --- M flashchips.c 1 file changed, 22 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/35037/2