Attention is currently required from: Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69267 )
Change subject: tests: Detect llvm coverage run and redirect to real I/O functions ......................................................................
Patch Set 11:
(8 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69267/comment/5924adf4_e81e7089 PS10, Line 7: tests: Detect llvm coverage file io and unmock io functions
Could you please re-use my comments for commit message from the previous patch into here, too? thank […]
Done
https://review.coreboot.org/c/flashrom/+/69267/comment/4c12222e_50f8d393 PS10, Line 7: tests: Detect llvm coverage file io and unmock io functions
Could you please re-use my comments for commit message from the previous patch into here, too? thank […]
Done
File Documentation/building.md:
https://review.coreboot.org/c/flashrom/+/69267/comment/a0b1b637_d8cb1513 PS10, Line 52: : #### gcc / gcov
This line needs to be in a previous patch, where the section is added
Done
https://review.coreboot.org/c/flashrom/+/69267/comment/639d2953_cecefdb2 PS10, Line 52: : #### gcc / gcov
This line needs to be in a previous patch, where the section is added
Done
File tests/unmock_io.c:
https://review.coreboot.org/c/flashrom/+/69267/comment/6a3bbc0d_f2448b42 PS10, Line 32: (void)state;
can be dropped
Done
https://review.coreboot.org/c/flashrom/+/69267/comment/ccfad5f8_0fcaea72 PS10, Line 32: (void)state;
can be dropped
Done
https://review.coreboot.org/c/flashrom/+/69267/comment/d71111e7_6de1a74a PS10, Line 79: ".gcda"
Can this go into macro at the beginning of the file? […]
only used here so i made a variable same diff
https://review.coreboot.org/c/flashrom/+/69267/comment/2da79c58_a150013a PS10, Line 79: ".gcda"
Can this go into macro at the beginning of the file? […]
Done