Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34661 )
Change subject: Add support for STLINK V3 debugger/programmer via its SPI bridge ......................................................................
Patch Set 9: Code-Review+1
(1 comment)
Sorry, I've run some additional tests and one more nit showed up. When this is fixed, I can merge it instantly :)
https://review.coreboot.org/c/flashrom/+/34661/9/stlinkv3_spi.c File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/34661/9/stlinkv3_spi.c@349 PS9, Line 349: for (unsigned int i = 0; (i < 8) && (i < write_cnt); i++) Some older compilers complain about the declaration inside the `for ()`. Please move the declaration up to the others.