Attention is currently required from: Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72656 )
Change subject: meson: use cfg_data for to evaluate cflags ......................................................................
Patch Set 1:
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/72656/comment/d7d2df39_9e7cd33a PS1, Line 481: : config.set('CONFIG_DEFAULT_PROGRAMMER_NAME', get_option('default_programmer_name') != '' ? '&programmer_' + get_option('default_programmer_name') : 'NULL')
not sure I like the embedded ternary operator use in this case, could it be assigned to a intermedia […]
You know, I would like to remove the `CONFIG_DEFAULT_PROGRAMMER`. It accesses parts which should not be accessible by the cli and also alters the default behavior based on compile time decisions. In an automated job the programmer should given in the same way as the operation to perform.
I don't hang on the syntax and can change it.