Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44881 )
Change subject: support 4-byte address format for VARIOUS_SIZE dummy flash device ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/flashrom/+/44881/5/dummyflasher.c File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/44881/5/dummyflasher.c@718 PS5, Line 718: offs = writearr[1] << 24 | writearr[2] << 16 | : writearr[3] << 8 | writearr[4]; For better readability, converting this into one line.
https://review.coreboot.org/c/flashrom/+/44881/5/dummyflasher.c@740 PS5, Line 740: offs = writearr[1] << 24 | writearr[2] << 16 | : writearr[3] << 8 | writearr[4]; For better readability, converting this into one line.
https://review.coreboot.org/c/flashrom/+/44881/6/dummyflasher.c File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/44881/6/dummyflasher.c@753 PS6, Line 753: emu_modified = 1; Added this line in patch#6 after rebasing this on https://review.coreboot.org/c/flashrom/+/44907.