Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62898 )
Change subject: hwaccess: replace macros by C code
......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62898/comment/48cfa498_d73abedf
PS5, Line 9: seperate
sep*a*rate
Done
https://review.coreboot.org/c/flashrom/+/62898/comment/f8770b71_d8756fcc
PS5, Line 11: endiannes
one more `s`
Done
https://review.coreboot.org/c/flashrom/+/62898/comment/1cc594c3_455d5d9f
PS5, Line 12: swaped
another `p`, i.e. `swapped` also a lot in the code.
Done
Patchset:
PS6:
Patch set 6: mostly cosmetic fixes.
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/62898/comment/f602b9ed_d4215d17
PS5, Line 30: return ((value & (uint16_t)0x00ffU) << 8) |
Maybe add another space after `return` for alignment?
Done, corrected also the code of the function. This was the code from swap16, not swap8
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62898
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I86d38d816b37c283279c485fac8027f8fb94364a
Gerrit-Change-Number: 62898
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 18 Mar 2022 07:48:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment