20 Jun
2021
20 Jun
'21
11:56 p.m.
Attention is currently required from: Simon Buhrow, Nico Huber, Edward O'Callaghan, Samir Ibradžić. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand() ......................................................................
Patch Set 34: Code-Review+1
(1 comment)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/61b67166_866b9f73 PS34, Line 283: const size_t cmd_len = 3; /* same length for any ft2232 command */ If it is always the same, maybe it can be #define above?
--
To view, visit https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 34
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Samir Ibradžić sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Samir Ibradžić sibradzic@gmail.com
Gerrit-Comment-Date: Sun, 20 Jun 2021 23:56:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment