Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66373 )
Change subject: tree: provide flashrom context into programmer_delay() ......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66373/comment/8df8d34d_dd331af0 PS7, Line 14: TOPIC=register_master_api
I can add that into the commit message of my patch sure and will push once this lands so its rebased […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/66373/comment/266a72f8_e7ac6ee2 PS9, Line 11: state. Programmers uses internal delay can provide NULL as a context.
The commit message should mention that only the function signature is changed and that this commit h […]
Done
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/66373/comment/5fd3f59b_e9fb0eb2 PS7, Line 247: flashctx not needed (NULL) because pony_spi does not : * use it in its delay function.
A comment at the function declaration that you can pass flashctx but also NULL would be good.
Done