Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41656 )
Change subject: tests/spi25.c: Add unit-test coverage of spi95.c
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/41656/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/41656/1//COMMIT_MSG@7
PS1, Line 7: spi95.c
Oh, we have a file that is called spi95.c
Maybe mention in the commit message that it's added to spi25 because it's similar enough?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/41656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6de59451b82131b58114b268ff6dd0b18cd5952b
Gerrit-Change-Number: 41656
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 May 2020 12:34:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment