7 Sep
2022
7 Sep
'22
10:20 a.m.
Attention is currently required from: Felix Singer, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66883 )
Change subject: flashrom.c: Retype appropriate variables with bool ......................................................................
Patch Set 12: Code-Review+2
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66883/comment/e93124c9_a4cde213 PS12, Line 151: programmer_may_write = 1; This smells boolean, but it's taken care of in a follow-up
--
To view, visit https://review.coreboot.org/c/flashrom/+/66883
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4
Gerrit-Change-Number: 66883
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Wed, 07 Sep 2022 10:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment