Lachlan Bishop has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/45230 )
Change subject: dummyflasher.c: Factor out global state
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c@407
PS3, Line 407: sg_perr("Out of memory!\n");
: return 1;
this could later be cleaned up with a goto on the error paths but free(data) here
Done
https://review.coreboot.org/c/flashrom/+/45230/3/dummyflasher.c@459
PS3, Line 459: free(flashchip_contents);
: return 1;
free(data) here
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/45230
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I972b085875f1277d9ff33326669d2676a3bcd3aa
Gerrit-Change-Number: 45230
Gerrit-PatchSet: 4
Gerrit-Owner: Lachlan Bishop
lxb@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Sep 2020 07:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment