Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/68197 )
Change subject: tests/meson.build: Turn file list into list of file objects ......................................................................
tests/meson.build: Turn file list into list of file objects
When a file object is created, Meson also checks if the file actually exists and an error points to the specific line of meson.build if not. If just a list of filenames is used, then the error occurs at the line where the list is used.
Thus, use file objects in tests/meson.build for more useful error messages.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I0b9144a6b76c1772833817b4e6873818dcf36b05 Reviewed-on: https://review.coreboot.org/c/flashrom/+/68197 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Thomas Heijligen src@posteo.de --- M tests/meson.build 1 file changed, 24 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved
diff --git a/tests/meson.build b/tests/meson.build index e4f7c2a..c62cc1b 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -11,7 +11,7 @@ # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details.
-srcs = [ +srcs = files( 'io_mock.c', 'tests.c', 'libusb_wraps.c', @@ -31,7 +31,7 @@ 'layout.c', 'chip.c', 'chip_wp.c', -] +)
if not programmer.get('dummy').get('active') srcs += programmer.get('dummy').get('srcs')