21 Dec
2021
21 Dec
'21
5:05 p.m.
Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60110 )
Change subject: hwaccess: move x86 port I/O related code into own files ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/60110/comment/4ffd3f35_d89a2fa8 PS5, Line 786: x86 Should we guard this by ARCH,x86 right away? Then we wouldn't need the x86 checks inside the file, which would better match the name. (removing the checks could be a follow-up)
--
To view, visit https://review.coreboot.org/c/flashrom/+/60110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I372b4a409f036da766c42bc406b596bc41b0f75a
Gerrit-Change-Number: 60110
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Dec 2021 17:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment