20 Sep
2019
20 Sep
'19
7:35 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35478 )
Change subject: flashchips.c: Take GD25LQ128C/D from downstream ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35478/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/35478/1/flashchips.c@a5919 PS1, Line 5919: printlock I think you can't remove this as it will create a NULL ptr deref in the dispatch site? Also why remove it?
--
To view, visit https://review.coreboot.org/c/flashrom/+/35478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4358392520507ddbfc654feb49fa982d49db2f28
Gerrit-Change-Number: 35478
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 20 Sep 2019 05:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment