4 Nov
2022
4 Nov
'22
3:46 p.m.
Attention is currently required from: Nico Huber, David Hendricks, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31012 )
Change subject: cli_classic: Report the gathered layout entries at level dbg ......................................................................
Patch Set 3:
(1 comment)
File layout.c:
https://review.coreboot.org/c/flashrom/+/31012/comment/ccdde6b5_3aa9fbbf PS3, Line 436: l->num_entries
I guess this would become `i`. Perhaps then: […]
Wouldn't that look weird, though? It would print the layout entries themselves, and then say what they are.
--
To view, visit https://review.coreboot.org/c/flashrom/+/31012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7678ba5138f0d722ee44747fe123f192abdd0ffd
Gerrit-Change-Number: 31012
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Fri, 04 Nov 2022 14:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment