Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39532 )
Change subject: flashchips: Add Macronix MX25R3235F
......................................................................
Patch Set 3:
Patch Set 2:
(4 comments)
Patch Set 1: Code-Review+1
(4 comments)
Just a few comments on the commit message. I'm sorry that it took me so long to review.
Thnx!
All sorted out & "Fixed:" reference to GH issue added as suggested by Paul.
Can we have it merged please?
Cheers
Perfect, thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/39532
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6e79115adba17d13d24bc85d78707d53fd4a0be5
Gerrit-Change-Number: 39532
Gerrit-PatchSet: 3
Gerrit-Owner: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Mar 2020 15:48:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment