Nico Huber has posted comments on this change. ( https://review.coreboot.org/21923 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/21923/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/21923/1//COMMIT_MSG@21 PS1, Line 21: white space errors white-space errors (I've never understood the rules that you find about it on the internet. For me everything in English without a dash reads right-associative. Could be wrong...)
https://review.coreboot.org/#/c/21923/1//COMMIT_MSG@28 PS1, Line 28: - existing signoffs and acks in all new commits One question here, what if you want to move a commit that was reviewed on gerrit to another branch (not handled by gerrit)? The commits likely won't have acks... add them manually, or change the script to allow Reviewed-by, too?