13 Dec
2022
13 Dec
'22
1:38 p.m.
Attention is currently required from: Edward O'Callaghan.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65642 )
Change subject: flashrom.c:Add function to align region to sector boundaries ......................................................................
Patch Set 60:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65642/comment/409a00bc_d257aa03 PS57, Line 1183: layout[i].layout_list[j]
for example, something like; […]
I feel this way the code is more easy to understand -- jth block according to ith erase function.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65642/comment/40cf549e_027e6489 PS58, Line 1181: int
also indexing array's with `unsigned int`
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/65642
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I215ea4986aa23360fc65ff761f4e49c6069160ac
Gerrit-Change-Number: 65642
Gerrit-PatchSet: 60
Gerrit-Owner: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 13 Dec 2022 13:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment